linux-kernel - Re: + task_struct-make-journal_info-conditional.patch added to -mm tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091204051729.GA3927@x200>
Date:	Fri, 4 Dec 2009 08:17:29 +0300
From:	Alexey Dobriyan <adobriyan@...il.com>
To:	Hiroshi Shimamoto <h-shimamoto@...jp.nec.com>
Cc:	linux-kernel@...r.kernel.org, mm-commits@...r.kernel.org,
	chris.mason@...cle.com, konishi.ryusuke@....ntt.co.jp,
	swhiteho@...hat.com, tytso@....edu
Subject: Re: + task_struct-make-journal_info-conditional.patch added to -mm
 tree

On Fri, Dec 04, 2009 at 12:58:06PM +0900, Hiroshi Shimamoto wrote:
> Alexey Dobriyan wrote:
> > On Thu, Dec 03, 2009 at 02:40:57PM -0800, akpm@...ux-foundation.org wrote:
> >> --- a/include/linux/sched.h~task_struct-make-journal_info-conditional
> >> +++ a/include/linux/sched.h
> >> @@ -1452,8 +1452,10 @@ struct task_struct {
> >>  	gfp_t lockdep_reclaim_gfp;
> >>  #endif
> >>  
> >> +#ifdef CONFIG_FS_JOURNAL_INFO
> >>  /* journalling filesystem info */
> >>  	void *journal_info;
> >> +#endif
> > 
> > This will prevent using e.g. ext3 on CONFIG_EXT3_FS=n kernels.
> 
> I'm sorry, I'm not sure what you're mentioning.

With this patch admin must decide in advance if he will ever use ext3.
EXT3_FS=n kernels won't be able to get ext3 support without reboot
even as module, because task_struct will be different.

Which is a regression compared to current state.

The biggest example of such behaviour is ipv6 module, but it should not
be spread more.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/