linux-kernel - Re: [PATCH 06/31] Constify struct e1000_mac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4B19B4FA.5080904@gmail.com>
Date:	Sat, 05 Dec 2009 02:18:50 +0100
From:	Emese Revfy <re.emese@...il.com>
To:	Stephen Rothwell <sfr@...b.auug.org.au>
CC:	jeffrey.t.kirsher@...el.com, jesse.brandeburg@...el.com,
	bruce.w.allan@...el.com, peter.p.waskiewicz.jr@...el.com,
	john.ronciak@...el.com, torvalds@...ux-foundation.org,
	linux-kernel@...r.kernel.org, davem@...emloft.net,
	netdev@...r.kernel.org
Subject: Re: [PATCH 06/31] Constify struct e1000_mac_operations for 2.6.32
 v1

Stephen Rothwell wrote:
> Hi Emese,
> 
> On Sat, 05 Dec 2009 01:03:03 +0100 Emese Revfy <re.emese@...il.com> wrote:
>> --- a/drivers/net/e1000e/82571.c
>> +++ b/drivers/net/e1000e/82571.c
>> @@ -212,6 +212,7 @@ static s32 e1000_init_mac_params_82571(struct e1000_adapter *adapter)
>>  {
>>  	struct e1000_hw *hw = &adapter->hw;
>>  	struct e1000_mac_info *mac = &hw->mac;
>> +	/* cannot be const */
>>  	struct e1000_mac_operations *func = &mac->ops;
> 
> Adding to the comment to say why it can't be const may allow us to fix
> this later ...

Ok, in the next patch series I will explain each case.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/