linux-kernel - Re: [PATCH] x86: Put trampoline

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4B19FAD5.5020802@zytor.com>
Date:	Fri, 04 Dec 2009 22:16:53 -0800
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Rakib Mullick <rakib.mullick@...il.com>
CC:	Ingo Molnar <mingo@...e.hu>, Thomas Gleixner <tglx@...utronix.de>,
	LKML <linux-kernel@...r.kernel.org>, x86@...nel.org,
	"Cihula, Joseph" <joseph.cihula@...el.com>,
	Shane Wang <shane.wang@...el.com>
Subject: Re: [PATCH] x86: Put trampoline_data into readonly section.

On 12/04/2009 08:47 PM, Rakib Mullick wrote:
> On 12/5/09, H. Peter Anvin<hpa@...or.com>  wrote:
>> On 12/04/2009 08:24 AM, Rakib Mullick wrote:
>>
>>   Perhaps the better thing would be to define trampoline_size as an
>>   absolute symbol in arch/x86/kernel/trampoline_*.S, especially since it
>>   probably generates bad code to subtract two global symbols like that.
>>
> But - trampoline_data is placed into - cpu init readonly data section.
> And we are
> referencing it from non-cpuinit function. ....... so I think the
> problem remains.
> Isn't it ? Or am I missing anything?
>

No, we're not actually referencing it at all.  We're just using its 
length, whereas in reality we actually have copied the code elsewhere 
already.

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/