linux-kernel - Re: [PATCH net-next-2.6] drivers/net: Move && and || to end of previous line

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <4B1A557D.4080707@gmail.com>
Date:	Sat, 05 Dec 2009 07:43:41 -0500
From:	William Allen Simpson <william.allen.simpson@...il.com>
To:	Joe Perches <joe@...ches.com>
CC:	Brice Goglin <brice@...i.com>, David Miller <davem@...emloft.net>,
	netdev@...r.kernel.org,
	Linux Kernel Developers <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next-2.6] drivers/net: Move && and || to end of previous
 line

Joe Perches wrote:
> On Fri, 2009-12-04 at 14:10 +0100, Brice Goglin wrote:
>> Joe Perches wrote:
>>> Only files where David Miller is the primary git-signer.
>>> wireless, wimax, ixgbe, etc are not modified.
>> What's the point? Having them at the beginning of the next line is
>> easier to read from my point of view.
> 
> It's just a stupid consistency thing.
> 
Brice, I've made my objection known on the LKML.  Joe *agrees* that
having them on the beginning of the line is preferred.  Thousands of
contributors throughout the tree agree.

This is entirely a Miller thing.

My main objection to these sweeping patches is that it makes it much
more difficult to maintain and apply patches across different versions of
the tree.  We have already seen conflicts with other git maintained trees.

These patches should not be accepted to the main Linus tree.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/