linux-kernel - Re: [stable] x86: Remove STACKPROTECTOR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4B1C3D25.4010903@mandriva.org>
Date:	Mon, 07 Dec 2009 01:24:21 +0200
From:	Thomas Backlund <tmb@...driva.org>
To:	Greg KH <greg@...ah.com>
CC:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	stable@...nel.org
Subject: Re: [stable] x86: Remove STACKPROTECTOR_ALL

Greg KH skrev:
> On Wed, Nov 11, 2009 at 12:23:16AM +0200, Thomas Backlund wrote:
>> I think this one should go to 2.6.31.x too ...
>>
>>> Gitweb:     http://git.kernel.org/linus/14a3f40aafacde1dfd6912327ae14df4baf10304
>>> Commit:     14a3f40aafacde1dfd6912327ae14df4baf10304
>>> Parent:     02dd0a0613e0d84c7dd8315e3fe6204d005b7c79
>>> Author:     Arjan van de Ven <arjan@...radead.org>
>>> AuthorDate: Fri Oct 23 07:31:01 2009 -0700
>>> Committer:  Ingo Molnar <mingo@...e.hu>
>>> CommitDate: Fri Oct 23 16:35:23 2009 +0200
>>>
>>>     x86: Remove STACKPROTECTOR_ALL
>>>     
>>>     STACKPROTECTOR_ALL has a really high overhead (runtime and stack
>>>     footprint) and is not really worth it protection wise (the
>>>     normal STACKPROTECTOR is in effect for all functions with
>>>     buffers already), so lets just remove the option entirely.
>>>     
>>>     Reported-by: Dave Jones <davej@...hat.com>
>>>     Reported-by: Chuck Ebbert <cebbert@...hat.com>
>>>     Signed-off-by: Arjan van de Ven <arjan@...ux.intel.com>
>>>     Cc: Eric Sandeen <sandeen@...hat.com>
>>>     LKML-Reference: <20091023073101.3dce4ebb@...radead.org>
>>>     Signed-off-by: Ingo Molnar <mingo@...e.hu>
> 
> It doesn't really "fix" anything, so I'd prefer not too.
> 

The reason for I suggested it was that is's supposed to remove some
bloating, and reportedly xfs from blowing up:

http://marc.info/?l=linux-kernel&m=125614028227106&w=2

But anyway, it's your call...

--
Thomas

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/