[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20091207071008.GE10868@elte.hu>
Date: Mon, 7 Dec 2009 08:10:08 +0100
From: Ingo Molnar <mingo@...e.hu>
To: Ulrich Drepper <drepper@...hat.com>
Cc: a.p.zijlstra@...llo.nl, fweisbec@...il.com,
jaswinderrajput@...il.com, linux-kernel@...r.kernel.org,
paulus@...ba.org
Subject: Re: Minor optimization in parse_subsystem_tracepoint_event
* Ulrich Drepper <drepper@...hat.com> wrote:
> Uses of strcat are almost always signs that someone is too lazy to think
> about the code a bit more carefully. One always has to know about the
> lengths of the strings involved to avoid buffer overflows.
>
> This is one case where the size of the object code for me is reduced by
> 38 bytes. The code should also be faster, especially if flags is non-NULL.
>
> Signed-off-by: Ulrich Drepper <drepper@...hat.com>
Applied, thanks a lot Ulrich!
Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists