linux-kernel - Re: [022/119] highmem: Fix debug_kmap_atomic() to also handle KM_IRQ_PTE, KM_NMI, and KM_NMI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:  <20091207105034.4dd2beac@schatten.dmk.lab>
Date:	Mon, 7 Dec 2009 10:50:34 +0100
From:	Florian Mickler <florian@...kler.org>
To:	linux-kernel@...r.kernel.org
Cc:	Hugh Dickins <hugh.dickins@...cali.co.uk>
Subject:  Re: [022/119] highmem: Fix debug_kmap_atomic() to also handle
 KM_IRQ_PTE, KM_NMI, and KM_NMI_PTE

On Mon, 7 Dec 2009 01:11:55 +0000 (GMT)
Hugh Dickins <hugh.dickins@...cali.co.uk> wrote:

> On Sun, 6 Dec 2009, Greg KH wrote:
> 
> > 2.6.31-stable review patch.  If anyone has any objections, please let us know.
> > 
> > ------------------
> > From: Soeren Sandmann <sandmann@...mi.au.dk>
> > 
> > commit d4515646699b6ad7b1a98ceb871296b957f3ef47 upstream.
> > 
> > Previously calling debug_kmap_atomic() with these types would
> > cause spurious warnings.
> > 
> > (triggered by SysProf using perf events)
> > 
> > Signed-off-by: Soeren Sandmann Pedersen <sandmann@...hat.com>
> > Cc: Linus Torvalds <torvalds@...ux-foundation.org>
> > Cc: a.p.zijlstra@...llo.nl
> > LKML-Reference: <ye8vdhz8krw.fsf@...el23.daimi.au.dk>
> > Signed-off-by: Ingo Molnar <mingo@...e.hu>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@...e.de>
> 
> IIRC, this patch caused build failures in a number of architectures,
> those which didn't already define KM_NMI, KM_NMI_PTE or KM_IRQ_PTE
> e.g. compare the 2.6.32 arch/arm/include/asm/kmap_types.h against
> its 2.6.31 version.
> 
> Should be fixable if you include the extras necessary, but I'm
> ashamed to say I've left that as an exercise for the reader ;)
> 
> Hugh

grepping the git log for KM_NMI did find these two fixes in linus tree:

e8105903d78c81119754a42926951d9d17e191ba powerpc: Fix DEBUG_HIGHMEM build break from d4515646699
4ff1fa278b0bd1b2dd3c42efc0cb86788ffe05d5 [ARM] kmap: fix build errors with DEBUG_HIGHMEM enabled

hth,
Flo

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/