linux-kernel - Re: [Patch] proc: fill 'lib' field in /proc/<pid>/statm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 07 Dec 2009 19:42:14 +0800
From:	Cong Wang <amwang@...hat.com>
To:	Hugh Dickins <hugh.dickins@...cali.co.uk>
CC:	linux-kernel@...r.kernel.org, Mel Gorman <mel@....ul.ie>,
	Alexey Dobriyan <adobriyan@...il.com>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	akpm@...ux-foundation.org, Al Viro <viro@...iv.linux.org.uk>
Subject: Re: [Patch] proc: fill 'lib' field in /proc/<pid>/statm

Hugh Dickins wrote:
> On Mon, 7 Dec 2009, Amerigo Wang wrote:
> 
>> Currently, the 'lib' field of /proc/<pid>/statm is
>> always 0, we should fill it with the right value,
>> the same with 'VmLib'.
> 
> The right value (if you're looking for consistency with Linux 2.4)
> is the number of currently resident "library" pages: and we don't
> know that number - we can't even define what a library is.

Hmm, the current algorithm is just kicking out text size of itself
from ->exec_vm, it really makes some sense, but not always.

> 
> We could add some code to make it show the same bogus number as
> we show somewhere else, but it has said 0 ever since 2.5.37: so
> I don't think it's worth a line of code myself, but bow to others.


If you mean 'VmLib' in /proc/<pid>/status, this is the same with it.

> 
>> Signed-off-by: WANG Cong <amwang@...hat.com>
>> Cc: Eric W. Biederman <ebiederm@...ssion.com>
>> Cc: Alexey Dobriyan <adobriyan@...il.com>
>> Cc: Al Viro <viro@...iv.linux.org.uk>
>> Cc: Mel Gorman <mel@....ul.ie>
>> Cc: stable@...nel.org
> 
> What does alarm me is that you think this is fit for -stable!
> 

Oh, sorry, I thought missing this field is a mistake...
Dropped.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/