linux-kernel - Re: NFS lockdep lock misordering mmap_sem<->i_mutex

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091207132009.GI18989@one.firstfloor.org>
Date:	Mon, 7 Dec 2009 14:20:09 +0100
From:	Andi Kleen <andi@...stfloor.org>
To:	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
Cc:	Andi Kleen <andi@...stfloor.org>, linux-kernel@...r.kernel.org,
	Trond.Myklebust@...app.com
Subject: Re: NFS lockdep lock misordering mmap_sem<->i_mutex_key with 2.6.32-git1

On Mon, Dec 07, 2009 at 09:19:28PM +0900, KOSAKI Motohiro wrote:
> > 
> > While booting 2.6.32-git1 on a NFS root box I got the following
> > lockdep warning early at boot. I haven't looked at details.
> 
> It seems typical ABBA deadlock.
> 
>  vfs_readdir				[grab i_mutex]
>    nfs_readdir
>      nfs_do_filldir
>        filldir
>          copy_to_user
>            [page_fault]			[grab mmap_sem]
> 
>  sys_mmap				[grab mmap_sem]
>    do_mmap_pgoff
>      mmap_region
>        nfs_file_mmap
>          nfs_revalidate_mapping  
>            nfs_invalidate_mapping	[grab i_mutex]
> 
> I guess recent lockdep improvement find old bug.

Thanks for the analysis.

I guess should never do copy_*_user while holding i_mutex? There might
be lots of cases like that.

-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/