linux-kernel - Re: [PATCH] tty: PTR_ERR return of wrong pointer in fs3270

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20091207150342.23a6cb66@mschwide.boeblingen.de.ibm.com>
Date:	Mon, 7 Dec 2009 15:03:42 +0100
From:	Martin Schwidefsky <schwidefsky@...ibm.com>
To:	Roel Kluin <roel.kluin@...il.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] tty: PTR_ERR return of wrong pointer in fs3270_open()

On Mon, 07 Dec 2009 14:33:39 +0100
Roel Kluin <roel.kluin@...il.com> wrote:

> Return the PTR_ERR of the correct pointer.
> 
> Signed-off-by: Roel Kluin <roel.kluin@...il.com>
> ---
>  drivers/s390/char/fs3270.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/s390/char/fs3270.c b/drivers/s390/char/fs3270.c
> index 097d384..2ae58d0 100644
> --- a/drivers/s390/char/fs3270.c
> +++ b/drivers/s390/char/fs3270.c
> @@ -465,7 +465,7 @@ fs3270_open(struct inode *inode, struct file *filp)
>  	if (IS_ERR(ib)) {
>  		raw3270_put_view(&fp->view);
>  		raw3270_del_view(&fp->view);
> -		rc = PTR_ERR(fp);
> +		rc = PTR_ERR(ib);
>  		goto out;
>  	}
>  	fp->rdbuf = ib;

And added this one as well.

-- 
blue skies,
   Martin.

"Reality continues to ruin my life." - Calvin.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/