linux-kernel - [PATCH] don't include asm/hw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200912071712.58650.arnd@arndb.de>
Date:	Mon, 7 Dec 2009 17:12:58 +0100
From:	Arnd Bergmann <arnd@...db.de>
To:	Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:	linux-kernel@...r.kernel.org,
	Frederic Weisbecker <fweisbec@...il.com>,
	Alan Stern <stern@...land.harvard.edu>,
	"K.Prasad" <prasad@...ux.vnet.ibm.com>, Ingo Molnar <mingo@...e.hu>
Subject: [PATCH] don't include asm/hw_breakpoint.h in user space

asm/hw_breakpoint.h is evidently a kernel internal file and should
not be included globally, not even under an #ifdef.

Signed-off-by: Arnd Bergmann <arnd@...db.de>

---
On Sunday 06 December 2009, Geert Uytterhoeven wrote:
> `make headers_check' now complains:
> 
> usr/include/linux/perf_event.h:22: included file
> 'asm-m68k/hw_breakpoint.h' is not exported
> 
> although CONFIG_HAVE_HW_BREAKPOINT is not set.
> 
> As <asm/hw_breakpoint.h> exists for x86 only, I guess every one else
> is suffering from this.

Even on x86, that header is not exported.

--- a/include/linux/perf_event.h
+++ b/include/linux/perf_event.h
@@ -18,10 +18,6 @@
 #include <linux/ioctl.h>
 #include <asm/byteorder.h>
 
-#ifdef CONFIG_HAVE_HW_BREAKPOINT
-#include <asm/hw_breakpoint.h>
-#endif
-
 /*
  * User-space ABI bits:
  */
@@ -451,6 +447,10 @@ enum perf_callchain_context {
 # include <asm/perf_event.h>
 #endif
 
+#ifdef CONFIG_HAVE_HW_BREAKPOINT
+#include <asm/hw_breakpoint.h>
+#endif
+
 #include <linux/list.h>
 #include <linux/mutex.h>
 #include <linux/rculist.h>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/