linux-kernel - Re: [PATCH] SLAB: Fix slab_test.c CONFIG_CPUMASK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.00.0912071150140.1208@router.home>
Date:	Mon, 7 Dec 2009 11:50:47 -0600 (CST)
From:	Christoph Lameter <cl@...ux-foundation.org>
To:	Pekka Enberg <penberg@...helsinki.fi>
cc:	linux-kernel@...r.kernel.org, sfr@...b.auug.org.au
Subject: Re: [PATCH] SLAB: Fix slab_test.c CONFIG_CPUMASK_OFFSTACK build

On Mon, 7 Dec 2009, Pekka Enberg wrote:

> index e97afc4..0d23dc1 100644
> --- a/tests/slab_test.c
> +++ b/tests/slab_test.c
> @@ -170,10 +170,13 @@ static int started;
>  static int test_func(void *private)
>  {
>  	struct test_struct *t = private;
> -	cpumask_t newmask = CPU_MASK_NONE;
> +	cpumask_var_t newmask;
>
> -        cpu_set(t->cpu, newmask);
> -        set_cpus_allowed(current, newmask);

Whitespace damage?

> +	if (!alloc_cpumask_var(&newmask, GFP_KERNEL))
> +		return -ENOMEM;
> +
> +        cpumask_set_cpu(t->cpu, newmask);
> +        set_cpus_allowed_ptr(current, newmask);
>  	t->v = kzalloc(t->count * sizeof(void *), GFP_KERNEL);
>
>  	atomic_inc(&tests_running);
> @@ -188,6 +191,7 @@ static int test_func(void *private)
>  		t->test_p2(t);
>  	t->stop2 = get_cycles();
>  	kfree(t->v);
> +	free_cpumask_var(newmask);
>  	atomic_dec(&tests_running);
>  	set_current_state(TASK_UNINTERRUPTIBLE);
>  	schedule();

Reviewed-by: Christoph Lameter <cl@...ux-foundation.org>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/