linux-kernel - Re: [PATCH] tracing - fix function graph trace to properly display failed entries

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 7 Dec 2009 21:21:49 +0100
From:	Frederic Weisbecker <fweisbec@...il.com>
To:	Jiri Olsa <jolsa@...hat.com>
Cc:	Steven Rostedt <rostedt@...dmis.org>, mingo@...e.hu,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tracing - fix function graph trace to properly display
	failed entries

On Fri, Dec 04, 2009 at 11:46:16AM +0100, Jiri Olsa wrote:
> > sure, but it is not the trace_seq structure that overflows, it is the bare 
> > seq_file underneath. The s_show calls "trace_print_seq":
> > 
> > void trace_print_seq(struct seq_file *m, struct trace_seq *s)
> > {               
> >         int len = s->len >= PAGE_SIZE ? PAGE_SIZE - 1 : s->len;
> >         
> >         seq_write(m, s->buffer, len);
> > 
> >         trace_seq_init(s);
> > }               
> > 
> > it flushes the trace_seq to the seq_file and reinits the trace_seq.
> > But the seq_file will get filled in the end, ending up with
> > not displayed output in that case I described in the first email.
> > 
> 
> hi, any feedback on this?
> 
> thanks,
> jirka


Steven has done some tests and it looks like you were right, the
problem comes from the seq_file, not the trace_seq.

Steve, any news about it?

Thanks.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/