linux-kernel - Re: [PATCH] Fix tracing infrastructure to support multiple includes when defining CREATE_TRACE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091207205341.GH8073@hmsreliant.think-freely.org>
Date:	Mon, 7 Dec 2009 15:53:41 -0500
From:	Neil Horman <nhorman@...driver.com>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	linux-kernel@...r.kernel.org, fweisbec@...il.com, mingo@...hat.com,
	Mathieu Desnoyers <compudj@...stal.dyndns.org>,
	"David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH] Fix tracing infrastructure to support multiple
	includes when defining CREATE_TRACE_POINTS

On Mon, Dec 07, 2009 at 03:49:26PM -0500, Steven Rostedt wrote:
> On Mon, 2009-12-07 at 15:47 -0500, Steven Rostedt wrote:
> 
> > > 
> > > Note this patch also converts the napi_poll tracepoint to a TRACE_EVENT.  This
> > > is done so that the TRACE_EVENT fix doesn't break the build, and because its
> > > rather pointless I think given the current tracing infrastructure to not have
> > > napi_poll be an independent event.
> > > 
> > > Signed-off-by: Neil Horman <nhorman@...driver.com>
> > 
> > Thanks, I'll give it a test. But because this now touches networking
> > code, I need an Acked-by from David Miller before I can pull it in.
> > 
> > -- Steve
> > 
> > 
> > 
> > > 
> > > 
> > > linux/tracepoint.h   |   45 +++++++++++++++++++++++----------------------
> > > trace/define_trace.h |    1 +
> > > trace/events/napi.h  |   25 ++++++++++++++++++++++---
> 
> Hmm, This really isn't networking code. But still, a patch that changes
> the way a networking trace point works, I would rather have an ack.
> 
> Thanks,
> 
Copy that, I agree an Ack from dave is called for here, but Just FYi, theres
only one user of this tracepoint currently in the tree (the drop monitor) and
this change has no bearing on it, as you can still hook the tracepoint with the
same register_trace_napi_poll call

Neil

> -- Steve
> 
> > > 3 files changed, 46 insertions(+), 25 deletions(-)
> > > 
> > > diff --git a/include/linux/tracepoint.h b/include/linux/tracepoint.h
> > > index 2aac8a8..311abbf 100644
> > > --- a/include/linux/tracepoint.h
> > > +++ b/include/linux/tracepoint.h
> > > @@ -58,28 +58,6 @@ struct tracepoint {
> > >  		rcu_read_unlock_sched_notrace();			\
> > >  	} while (0)
> > >  
> 
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/