| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20091208070915.GC12264@elf.ucw.cz> Date: Tue, 8 Dec 2009 08:09:15 +0100 From: Pavel Machek <pavel@....cz> To: Wu Zhangjin <wuzhangjin@...il.com> Cc: Ralf Baechle <ralf@...ux-mips.org>, akpm@...ux-foundation.org, linux-mips@...ux-mips.org, linux-kernel@...r.kernel.org, Dmitry Torokhov <dmitry.torokhov@...il.com>, "Rafael J . Wysocki" <rjw@...k.pl>, zhangfx@...ote.com, linux-laptop@...r.kernel.org, Stephen Rothwell <sfr@...b.auug.org.au> Subject: Re: [PATCH v8 5/8] Loongson: YeeLoong: add hardware monitoring driver > > > > That's certainly better. But... why not return signed value? Current > > > > flowing from the battery is certainly very different from current > > > > flowing into it... > > > > > > You are totally right ;) > > > > > > Just test it, when flowing from the battery, the value is negative, and > > > when flowing into the battery, the value is positive, so, no abs() > > > needed. thanks! > > > > Make it return -value, then. I believe other code uses >0 values for > > discharge. > > Done, but any document/standard about it? Not sure, feel free to patch the documentation, too :-). Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists