linux-kernel - Re: [PATCH] mm/vmalloc: don't use vmalloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <4B1E1B1B0200007800024345@vpn.id2.novell.com>
Date:	Tue, 08 Dec 2009 08:23:39 +0000
From:	"Jan Beulich" <JBeulich@...ell.com>
To:	"Andrew Morton" <akpm@...ux-foundation.org>
Cc:	<tony.luck@...el.com>, <tj@...nel.org>, <linux-mm@...ck.org>,
	"Geert Uytterhoeven" <geert@...ux-m68k.org>,
	<linux-ia64@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mm/vmalloc: don't use vmalloc_end

>>> Andrew Morton <akpm@...ux-foundation.org> 08.12.09 00:35 >>>
>(cc linux-ia64)
>
>On Mon, 07 Dec 2009 16:24:03 +0000
>"Jan Beulich" <JBeulich@...ell.com> wrote:
>
>> At least on ia64 vmalloc_end is a global variable that VMALLOC_END
>> expands to. Hence having a local variable named vmalloc_end and
>> initialized from VMALLOC_END won't work on such platforms. Rename
>> these variables, and for consistency also rename vmalloc_start.
>> 
>
>erk.  So does 2.6.32's vmalloc() actually work correctly on ia64?

According to Tejun the problem is just cosmetic (i.e. causes build
warnings), since the functions affected aren't being used (yet) on
ia64. So feel free to drop the patch again, given that he has a patch
queued to address the issue by renaming the arch variable.

I wonder though why that code is being built on ia64 at all if it's not
being used (i.e. why it doesn't depend on a CONFIG_*, HAVE_*, or
NEED_* manifest constant).

Jan

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/