linux-kernel - Re: linux-next: percpu/tip tree build failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4B1E105E.7030208@kernel.org>
Date:	Tue, 08 Dec 2009 17:37:50 +0900
From:	Tejun Heo <tj@...nel.org>
To:	Ingo Molnar <mingo@...e.hu>
CC:	Frederic Weisbecker <fweisbec@...il.com>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	Rusty Russell <rusty@...tcorp.com.au>,
	Christoph Lameter <cl@...ux-foundation.org>,
	linux-next@...r.kernel.org, linux-kernel@...r.kernel.org,
	Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>,
	Peter Zijlstra <peterz@...radead.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: linux-next: percpu/tip tree build failure

Hello,

On 12/08/2009 05:24 PM, Ingo Molnar wrote:
>> Acked-by: Frederic Weisbecker <fweisbec@...il.com>
> 
> I have applied it - but really, the new percpu namespace changes headed 
> towards upstream are quite a nuisance IMO. The 3-4 (trivial to solve) 
> breakages i've seen so far affecting code i maintain give us an 
> estimation about the ongoing maintainence cost - which wont be high but 
> not zero either.
> 
> The change that was forced here:
> 
>  -static DEFINE_PER_CPU(unsigned int, task_bp_pinned[HBP_NUM]);
>  +static DEFINE_PER_CPU(unsigned int, nr_task_bp_pinned[HBP_NUM]);
> 
> Is it really an improvement to the old code?
>
> Dunno.

In each specific conflict, I don't think it would be an apparent
improvement but overall I do believe it's headed the right way.  Well,
or, at the very least, I don't see any other viable solution and
you're probably the most strongly affected by the change.  Sorry about
the inconveniences.

I'm waiting for ack for a m68k change before pushing out percpu tree.
I'm not completely determined but I think I'll keep dropping per_cpu__
prefix and sparse annotation in linux-next for one more cycle as
sparse annotation cleanup pass hasn't been done yet.  Once new devel
cycle begins, it might be a good idea to pull in percpu changes into
one of the tip trees so that these nuisances can be detected during
development?

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/