| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Mon, 7 Dec 2009 17:54:17 -0700 From: Dan Williams <dan.j.williams@...el.com> To: Guennadi Liakhovetski <g.liakhovetski@....de> Cc: linux-kernel@...r.kernel.org, linux-sh@...r.kernel.org, Nobuhiro Iwamatsu <iwamatsu.nobuhiro@...esas.com> Subject: Re: [PATCH 4/5] sh: stylistic improvements for the DMA driver On Fri, Dec 4, 2009 at 11:45 AM, Guennadi Liakhovetski <g.liakhovetski@....de> wrote: > Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@....de> > --- > drivers/dma/shdma.c | 34 +++++++++++++++++----------------- > drivers/dma/shdma.h | 14 +++++++------- > 2 files changed, 24 insertions(+), 24 deletions(-) > [..] > -static int dmae_is_idle(struct sh_dmae_chan *sh_chan) > +static int dmae_is_busy(struct sh_dmae_chan *sh_chan) This one isn't purely style, I agree with it, but think it would be a bit cleaner to return a bool rather than an error code. -- Dan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists