| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <9984.1260281967@redhat.com> Date: Tue, 08 Dec 2009 14:19:27 +0000 From: David Howells <dhowells@...hat.com> To: Jie Zhang <jie.zhang@...log.com> Cc: dhowells@...hat.com, Mike Frysinger <vapier@...too.org>, uclinux-dev@...inux.org, David McCullough <davidm@...pgear.com>, Greg Ungerer <gerg@...inux.org>, Paul Mundt <lethal@...ux-sh.org>, linux-kernel@...r.kernel.org, uclinux-dist-devel@...ckfin.uclinux.org Subject: Re: [PATCH] NOMMU: use copy_*_user_page() in access_process_vm() Jie Zhang <jie.zhang@...log.com> wrote: > I agree on using 0 instead of NULL. But for !MMU, I think, vaddr is always as > same as addr. So we don't need to pass it? FRV flushes the vaddr because in MMU mode the cache flush instructions take virtual addresses, so if we pass addr as vaddr, I can use the same cache flush code for both modes. I suspect it makes little difference to the amount of code if we pass that rather than 0, as the value is already computed, and either way, it's going to take one instruction to set up the argument. Note that Blackfin assumes that it may use the dst address for flushing - an assumption that isn't valid in MMU mode with a VIVT cache (which I presume Blackfin isn't, but other CPUs are). David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists