linux-kernel - Re: [PATCH] radio/sound/miro: fix build, cleanup depends/selects

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5hzl5tpen3.wl%tiwai@suse.de>
Date:	Tue, 08 Dec 2009 18:19:28 +0100
From:	Takashi Iwai <tiwai@...e.de>
To:	Randy Dunlap <randy.dunlap@...cle.com>
Cc:	lkml <linux-kernel@...r.kernel.org>,
	torvalds <torvalds@...ux-foundation.org>,
	Mauro Carvalho Chehab <mchehab@...radead.org>,
	Krzysztof Helt <krzysztof.h1@...pl>
Subject: Re: [PATCH] radio/sound/miro: fix build, cleanup depends/selects

At Tue, 8 Dec 2009 09:13:07 -0800,
Randy Dunlap wrote:
> 
> From: Randy Dunlap <randy.dunlap@...cle.com>
> 
> miropcm20 uses ALSA (snd_) interfaces from the SND_MIRO
> driver, so it should depend on SND.
> (selecting SND_MIRO when CONFIG_SND is not enabled is a
> problem.)
> 
> drivers/built-in.o: In function `vidioc_s_ctrl':
> radio-miropcm20.c:(.text+0x227499): undefined reference to `snd_aci_cmd'
> drivers/built-in.o: In function `vidioc_s_frequency':
> radio-miropcm20.c:(.text+0x227574): undefined reference to `snd_aci_cmd'
> radio-miropcm20.c:(.text+0x227588): undefined reference to `snd_aci_cmd'
> drivers/built-in.o: In function `pcm20_init':
> radio-miropcm20.c:(.init.text+0x2a784): undefined reference to `snd_aci_get_aci'
> 
> miropcm20 selects SND_MIRO but SND_ISA may be not enabled, so
> also select SND_ISA so that the snd-miro driver will be built.
> Otherwise there are missing symbols:
> 
> ERROR: "snd_opl4_create" [sound/isa/opti9xx/snd-miro.ko] undefined!
> ERROR: "snd_wss_pcm" [sound/isa/opti9xx/snd-miro.ko] undefined!
> ERROR: "snd_wss_timer" [sound/isa/opti9xx/snd-miro.ko] undefined!
> ERROR: "snd_wss_create" [sound/isa/opti9xx/snd-miro.ko] undefined!
> ERROR: "snd_wss_mixer" [sound/isa/opti9xx/snd-miro.ko] undefined!
> 
> Signed-off-by: Randy Dunlap <randy.dunlap@...cle.com>
> Acked-by: Mauro Carvalho Chehab <mchehab@...radead.org>
> Cc: Krzysztof Helt <krzysztof.h1@...pl>
> Cc: Takashi Iwai <tiwai@...e.de>

Thanks, applied to sound git tree now.
I'm going to send the second pull request tomorrow or so.


Takashi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/