linux-kernel - Re: [Resend] [PATCH] asus-laptop: add Lenovo SL LenovoCare LED support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 8 Dec 2009 18:32:15 +0100
From:	Corentin Chary <corentin.chary@...il.com>
To:	Matthew Garrett <mjg59@...f.ucam.org>
Cc:	Ike Panhc <ike.pan@...onical.com>, linux-acpi@...r.kernel.org,
	linux-kernel@...r.kernel.org, acpi4asus-user@...ts.sourceforge.net,
	Alexandre Rostovtsev <tetromino@...il.com>
Subject: Re: [Resend] [PATCH] asus-laptop: add Lenovo SL LenovoCare LED 
	support

On Tue, Dec 8, 2009 at 4:41 PM, Matthew Garrett <mjg59@...f.ucam.org> wrote:
> On Tue, Dec 08, 2009 at 03:37:09PM +0800, Ike Panhc wrote:
>
>>  ASUS_HANDLE(rled_set, ASUS_HOTK_PREFIX "RLED");      /* W1JC */
>>  ASUS_HANDLE(pled_set, ASUS_HOTK_PREFIX "PLED");      /* A7J */
>>  ASUS_HANDLE(gled_set, ASUS_HOTK_PREFIX "GLED");      /* G1, G2 (probably) */
>
> The driver is controlling the ATKD device, which has a HID of ATK0101.
> These devices are all underneath it...
>
>> +ASUS_HANDLE(lled_set, "\\_SB_.PCI0.SBRG.EC0_.HKEY.TVLS"); /* LenovoCare */
>
> And this one isn't, which is a bit jarring. Looking closer, it's under
> the LEN0014 device, which means that you're trying to touch a method
> that belongs to a device other than the one this driver is bound to.
> That's wrong. You want a separate ACPI driver for the LEN0014 device,
> and this should be called for there. Looking at it, you seem to get
> rfkill as well (the GWAN/SWAN, GBDC/SBDF and GUWB/SUWB methods) and
> maybe some other stuff.
>
> So this shouldn't go in asus-laptop. You'll need to add another separate
> driver for the SL-specific functionality.

That means asus-laptop and sl-laptop will be both needed for a SL
laptop, but I don't think this is a problem.



-- 
Corentin Chary
http://xf.iksaif.net
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/