linux-kernel - Re: [PATCH] arch/x86/kernel/microcode*: Use pr_fmt and remove duplicated KERN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091209072630.GA8187@elte.hu>
Date:	Wed, 9 Dec 2009 08:26:30 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Joe Perches <joe@...ches.com>
Cc:	Andy Whitcroft <apw@...onical.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Andreas Herrmann <herrmann.der.user@...glemail.com>
Subject: Re: [PATCH] arch/x86/kernel/microcode*: Use pr_fmt and remove
 duplicated KERN_ERR prefix


* Joe Perches <joe@...ches.com> wrote:

> On Wed, 2009-12-09 at 07:05 +0100, Ingo Molnar wrote:
> > > > -		printk(KERN_ERR "microcode: CPU%d: loading of chipset "
> > > > +		pr_err(KERN_ERR "microcode: CPU%d: loading of chipset "
> > > Duplicates KERN_ERR
> > Indeed - please send a delta fix as this has been merged already.
> 
> Use #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> Remove "microcode: " prefix from each pr_<level>
> Fix duplicated KERN_ERR prefix
> Coalesce pr_<level> format strings
> Add a space after an exclamation point
> No other change in output
> 
> Signed-off-by: Joe Perches <joe@...ches.com>
> ---
>  arch/x86/kernel/microcode_amd.c   |   40 +++++++++++++++----------------
>  arch/x86/kernel/microcode_core.c  |   26 +++++++++++---------
>  arch/x86/kernel/microcode_intel.c |   47 +++++++++++++++---------------------
>  3 files changed, 53 insertions(+), 60 deletions(-)

very nice. I've applied it, thanks Joe!

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/