| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <86802c440912090010q3aa9c701u75fbba19d43308e0@mail.gmail.com>
Date: Wed, 9 Dec 2009 00:10:50 -0800
From: Yinghai Lu <yhlu.kernel@...il.com>
To: Michał Mirosław <mirq-linux@...e.qmqm.pl>
Cc: linux-kernel@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>,
Ingo Molnar <mingo@...hat.com>,
"H. Peter Anvin" <hpa@...or.com>, x86@...nel.org
Subject: Re: [PATCH 3/7] mtrr: Remove use_intel()
2009/12/8 Michał Mirosław <mirq-linux@...e.qmqm.pl>:
> Remove use_intel() and use is_cpu(INTEL) instead.
>
> .use_intel_if is duplicating information already found in .vendor, as
> the only combinations used are:
> generic: use_intel_if == 1, vendor == INTEL
> amd/cyrix/centaur: use_intel_if == 0, vendor != INTEL
>
> Signed-off-by: Michał Mirosław <mirq-linux@...e.qmqm.pl>
> ---
> arch/x86/kernel/cpu/mtrr/generic.c | 1 -
> arch/x86/kernel/cpu/mtrr/main.c | 14 +++++++-------
> arch/x86/kernel/cpu/mtrr/mtrr.h | 2 --
> arch/x86/kernel/cpu/mtrr/state.c | 10 +++++-----
> 4 files changed, 12 insertions(+), 15 deletions(-)
>
> diff --git a/arch/x86/kernel/cpu/mtrr/generic.c b/arch/x86/kernel/cpu/mtrr/generic.c
> index 4d75584..1651877 100644
> --- a/arch/x86/kernel/cpu/mtrr/generic.c
> +++ b/arch/x86/kernel/cpu/mtrr/generic.c
> @@ -753,7 +753,6 @@ int positive_have_wrcomb(void)
> * Generic structure...
> */
> const struct mtrr_ops generic_mtrr_ops = {
> - .use_intel_if = 1,
> .set_all = generic_set_all,
> .get = generic_get_mtrr,
> .get_free_region = generic_get_free_region,
> diff --git a/arch/x86/kernel/cpu/mtrr/main.c b/arch/x86/kernel/cpu/mtrr/main.c
> index 628f3dd..bc3436e 100644
> --- a/arch/x86/kernel/cpu/mtrr/main.c
> +++ b/arch/x86/kernel/cpu/mtrr/main.c
> @@ -107,7 +107,7 @@ static void __init set_num_var_ranges(void)
> {
> unsigned long config = 0, dummy;
>
> - if (use_intel())
> + if (is_cpu(INTEL))
> rdmsr(MSR_MTRRcap, config, dummy);
> else if (is_cpu(AMD))
> config = 2;
> @@ -692,7 +692,7 @@ void __init mtrr_bp_init(void)
> if (mtrr_if) {
> set_num_var_ranges();
> init_table();
> - if (use_intel()) {
> + if (is_cpu(INTEL)) {
> get_mtrr_state();
>
> if (mtrr_cleanup(phys_addr)) {
> @@ -705,7 +705,7 @@ void __init mtrr_bp_init(void)
>
> void mtrr_ap_init(void)
> {
> - if (!use_intel() || mtrr_aps_delayed_init)
> + if (!is_cpu(INTEL) || mtrr_aps_delayed_init)
> return;
> /*
> * Ideally we should hold mtrr_mutex here to avoid mtrr entries
> @@ -733,7 +733,7 @@ void mtrr_save_state(void)
>
> void set_mtrr_aps_delayed_init(void)
> {
> - if (!use_intel())
> + if (!is_cpu(INTEL))
> return;
>
> mtrr_aps_delayed_init = true;
> @@ -744,7 +744,7 @@ void set_mtrr_aps_delayed_init(void)
> */
> void mtrr_aps_init(void)
> {
> - if (!use_intel())
> + if (!is_cpu(INTEL))
> return;
>
> set_mtrr(~0U, 0, 0, 0);
> @@ -753,7 +753,7 @@ void mtrr_aps_init(void)
>
> void mtrr_bp_restore(void)
> {
> - if (!use_intel())
> + if (!is_cpu(INTEL))
> return;
>
> mtrr_if->set_all();
> @@ -764,7 +764,7 @@ static int __init mtrr_init_finialize(void)
> if (!mtrr_if)
> return 0;
>
> - if (use_intel()) {
> + if (is_cpu(INTEL)) {
> if (!changed_by_mtrr_cleanup)
> mtrr_state_warn();
> return 0;
> diff --git a/arch/x86/kernel/cpu/mtrr/mtrr.h b/arch/x86/kernel/cpu/mtrr/mtrr.h
> index be2867c..562e2e3 100644
> --- a/arch/x86/kernel/cpu/mtrr/mtrr.h
> +++ b/arch/x86/kernel/cpu/mtrr/mtrr.h
> @@ -13,7 +13,6 @@ extern unsigned int mtrr_usage_table[MTRR_MAX_VAR_RANGES];
>
> struct mtrr_ops {
> u32 vendor;
> - u32 use_intel_if;
> void (*set)(unsigned int reg, unsigned long base,
> unsigned long size, mtrr_type type);
> void (*set_all)(void);
> @@ -62,7 +61,6 @@ extern u64 size_or_mask, size_and_mask;
> extern const struct mtrr_ops *mtrr_if;
>
> #define is_cpu(vnd) (mtrr_if && mtrr_if->vendor == X86_VENDOR_##vnd)
> -#define use_intel() (mtrr_if && mtrr_if->use_intel_if == 1)
>
> extern unsigned int num_var_ranges;
> extern u64 mtrr_tom2;
> diff --git a/arch/x86/kernel/cpu/mtrr/state.c b/arch/x86/kernel/cpu/mtrr/state.c
> index dfc80b4..3bdbf50 100644
> --- a/arch/x86/kernel/cpu/mtrr/state.c
> +++ b/arch/x86/kernel/cpu/mtrr/state.c
> @@ -17,7 +17,7 @@ void set_mtrr_prepare_save(struct set_mtrr_context *ctxt)
> /* Disable interrupts locally */
> local_irq_save(ctxt->flags);
>
> - if (use_intel() || is_cpu(CYRIX)) {
> + if (is_cpu(INTEL) || is_cpu(CYRIX)) {
>
> /* Save value of CR4 and clear Page Global Enable (bit 7) */
> if (cpu_has_pge) {
> @@ -34,7 +34,7 @@ void set_mtrr_prepare_save(struct set_mtrr_context *ctxt)
> write_cr0(cr0);
> wbinvd();
>
> - if (use_intel()) {
> + if (is_cpu(INTEL)) {
> /* Save MTRR state */
> rdmsr(MSR_MTRRdefType, ctxt->deftype_lo, ctxt->deftype_hi);
> } else {
> @@ -49,7 +49,7 @@ void set_mtrr_prepare_save(struct set_mtrr_context *ctxt)
>
> void set_mtrr_cache_disable(struct set_mtrr_context *ctxt)
> {
> - if (use_intel()) {
> + if (is_cpu(INTEL)) {
> /* Disable MTRRs, and set the default type to uncached */
> mtrr_wrmsr(MSR_MTRRdefType, ctxt->deftype_lo & 0xf300UL,
> ctxt->deftype_hi);
> @@ -64,13 +64,13 @@ void set_mtrr_cache_disable(struct set_mtrr_context *ctxt)
> /* Restore the processor after a set_mtrr_prepare */
> void set_mtrr_done(struct set_mtrr_context *ctxt)
> {
> - if (use_intel() || is_cpu(CYRIX)) {
> + if (is_cpu(INTEL) || is_cpu(CYRIX)) {
>
> /* Flush caches and TLBs */
> wbinvd();
>
> /* Restore MTRRdefType */
> - if (use_intel()) {
> + if (is_cpu(INTEL)) {
> /* Intel (P6) standard MTRRs */
> mtrr_wrmsr(MSR_MTRRdefType, ctxt->deftype_lo,
> ctxt->deftype_hi);
> --
can you check it with amd64 cpu?
YH
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists