linux-kernel - Re: [PATCH 01/10] trace_kprobe: shows signs of fields in format files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4B1FBC9E.5040903@redhat.com>
Date:	Wed, 09 Dec 2009 10:05:02 -0500
From:	Masami Hiramatsu <mhiramat@...hat.com>
To:	Lai Jiangshan <laijs@...fujitsu.com>
CC:	Ingo Molnar <mingo@...e.hu>, Steven Rostedt <rostedt@...dmis.org>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Jason Baron <jbaron@...hat.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 01/10] trace_kprobe: shows signs of fields in format files

Lai Jiangshan wrote:
>
> format files of trace_kprobe don't shows signs, it is
> different from all other format files, incorrect API to user.
>
> Signed-off-by: Lai Jiangshan<laijs@...fujitsu.com>

Thanks Lai!
Acked-by: Masami Hiramatsu <mhiramat@...hat.com>

> ---
> diff --git a/kernel/trace/trace_kprobe.c b/kernel/trace/trace_kprobe.c
> index e3c80e9..3ef66d4 100644
> --- a/kernel/trace/trace_kprobe.c
> +++ b/kernel/trace/trace_kprobe.c
> @@ -1163,10 +1163,11 @@ static int __probe_event_show_format(struct trace_seq *s,
>   #undef SHOW_FIELD
>   #define SHOW_FIELD(type, item, name)					\
>   	do {								\
> -		ret = trace_seq_printf(s, "\tfield: " #type " %s;\t"	\
> -				"offset:%u;\tsize:%u;\n", name,		\
> +		ret = trace_seq_printf(s, "\tfield:" #type " %s;\t"	\
> +				"offset:%u;\tsize:%u;\tsigned:%d;\n", name,\
>   				(unsigned int)offsetof(typeof(field), item),\
> -				(unsigned int)sizeof(type));		\
> +				(unsigned int)sizeof(type),		\
> +				is_signed_type(type));			\
>   		if (!ret)						\
>   			return 0;					\
>   	} while (0)
>
>
>

-- 
Masami Hiramatsu

Software Engineer
Hitachi Computer Products (America), Inc.
Software Solutions Division

e-mail: mhiramat@...hat.com

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/