linux-kernel - Re: [PATCH] Coding style correction on some drivers that use Generic HDLC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4B1FC5A4.9030300@bfs.de>
Date:	Wed, 09 Dec 2009 16:43:32 +0100
From:	walter harms <wharms@....de>
To:	Jan Yenya Kasprzak <kas@...muni.cz>
Cc:	Rudy Matela <rudy.matela@...il.com>,
	Krzysztof Halasa <khc@...waw.pl>, trivial@...nel.org,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] Coding style correction on some drivers that use Generic
 HDLC



Jan Yenya Kasprzak schrieb:
> Rudy Matela wrote:
> : Added a space separating some if/switch/while keywords from the following
> : parenthesis to conform to the CodingStyle.
> 
> 	Hello,
> 
> 	I am not sure whether it is necessary to fix formating mistakes in
> a driver which is in deep freeze and the hardware is not produced anymore,
> but whatever.
> 
> Acked-By: Jan "Yenya" Kasprzak <kas@...muni.cz>
> 
> -Yenya
> 
> : Signed-off-by: Rudy Matela <rudy.matela@...il.com>
> : ---
> : 
> :  drivers/net/wan/cosa.c       |   10 +++++-----
> :  drivers/net/wan/hdlc_cisco.c |    8 ++++----
> :  drivers/net/wan/hdlc_x25.c   |    4 ++--
> :  3 files changed, 11 insertions(+), 11 deletions(-)
> : 
> : diff --git a/drivers/net/wan/cosa.c b/drivers/net/wan/cosa.c
> : index b36bf96..f0bd70f 100644
> 

It is ok until the driver is removed, if this "issue" is not fixed it will
trigger any check-coding-style and generate new patches. Since it involves
no code changes it is harmless.

re,
 wh

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/