linux-kernel - Re: [PATCH] drivers/char/nvram: Restore #include <linux/smp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20091209210559.GA7129@nowhere>
Date:	Wed, 9 Dec 2009 22:06:02 +0100
From:	Frederic Weisbecker <fweisbec@...il.com>
To:	Joe Perches <joe@...ches.com>
Cc:	Thomas Gleixner <tglx@...utronix.de>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drivers/char/nvram: Restore #include <linux/smp_lock.h>

On Wed, Dec 09, 2009 at 01:03:40PM -0800, Joe Perches wrote:
> Commit 8587b33f4adee4e7614ea7f443346c3b6bb5427a removed
> the include, but it's still required for a different
> lock_kernel/unlock_kernel pair in nvram_open
> 
> Compiled: x86/defconfig
> 
> Signed-off-by: Joe Perches <joe@...ches.com>
> ---
> diff --git a/drivers/char/nvram.c b/drivers/char/nvram.c
> index 2100a8f..3cfa0f6 100644
> --- a/drivers/char/nvram.c
> +++ b/drivers/char/nvram.c
> @@ -38,6 +38,7 @@
>  #define NVRAM_VERSION	"1.3"
>  
>  #include <linux/module.h>
> +#include <linux/smp_lock.h>
>  #include <linux/nvram.h>
>  
>  #define PC		1
> 
> 


I've already sent a fix for that.
See: nvram: Fix missing smp_lock.h in nvram

Thanks.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/