linux-kernel - Re: [PATCH 1/6] x86, 32-bit: Add new pt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4B203B48.3070906@zytor.com>
Date:	Wed, 09 Dec 2009 16:05:28 -0800
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Brian Gerst <brgerst@...il.com>
CC:	Ingo Molnar <mingo@...e.hu>, x86@...nel.org,
	torvalds@...ux-foundation.org, jeremy@...p.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/6] x86, 32-bit: Add new pt_regs stubs

On 12/09/2009 04:01 PM, Brian Gerst wrote:
> Add new stubs which add the pt_regs pointer as the last arg, matching
> 64-bit.  This will allow these syscalls to be easily merged.
> 
> Signed-off-by: Brian Gerst <brgerst@...il.com>
> +ptregs_##name: \
> +	leal 4(%esp),%edx; \
> +	movl PT_EBX(%edx),%eax; \
> +	jmp sys_##name;

You're introducing a completely unnecessary pipeline serialization here.
 Instead do:

	movl (PT_EBX+4)(%esp),%eax;

... making the statements independent and therefore executable in parallel.

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/