linux-kernel - Re: [PATCH] Coding style correction on some drivers that use Generic HDLC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20091209.164029.112221779.davem@davemloft.net>
Date:	Wed, 09 Dec 2009 16:40:29 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	jkosina@...e.cz
Cc:	rudy.matela@...il.com, wharms@....de, kas@...muni.cz,
	khc@...waw.pl, linux-kernel@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] Coding style correction on some drivers that use
 Generic HDLC

From: Jiri Kosina <jkosina@...e.cz>
Date: Thu, 10 Dec 2009 00:26:57 +0100 (CET)

> On Wed, 9 Dec 2009, Rudy Matela wrote:
> 
>> > It is ok until the driver is removed, if this "issue" is not fixed it 
>> > will trigger any check-coding-style and generate new patches. Since it 
>> > involves no code changes it is harmless.
>>   Sould I keep sending coding style corrections to the Linux Kernel?
>> I'm trying to help, but if i'm just being annoying, please tell me and
>> I can try to contribute in a better way.  :-)
> 
> Coding style corrections (if they really improve readability of the code), 
> comment fixes (if they really make grepping for things better or make the 
> whole text more understandable) are welcome and I will happily merge them.
> 
> What I usually don't merge are purely whitespace "fixes", which don't 
> really fix anything in fact.

I think the whitespace ones here are extremely valuable, the code is
amazingly annoying to read as it is.

It boils down to this:

	foo() is a C function call

	foo () is a C operation like 'if', 'while' etc.

and people's brains are wired to this association.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/