linux-kernel - Re: [PATCH 1/1] cxgb3i: Fix a login over vlan issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4B20FBA4.9040003@chelsio.com>
Date:	Thu, 10 Dec 2009 19:16:12 +0530
From:	Rakesh Ranjan <rakesh@...lsio.com>
To:	Patrick McHardy <kaber@...sh.net>
CC:	kxie@...lsio.com, linux-scsi@...r.kernel.org,
	open-iscsi@...glegroups.com, netdev@...r.kernel.org,
	davem@...emloft.net, James.Bottomley@...senPartnership.com,
	michaelc@...wisc.edu, linux-kernel@...r.kernel.org,
	Rakesh Ranjan <rakesh@...lsio.com>
Subject: Re: [PATCH 1/1] cxgb3i: Fix a login over vlan issue

Patrick McHardy wrote:
> kxie@...lsio.com wrote:
>> [PATCH 1/1] cxgb3i: Fix a login over vlan issue
>>
>> From: Karen Xie <kxie@...lsio.com>
>>
>> Fix a login over vlan issue, when parent interface is vlan and we are using
>>
>> cxgb3i sepecific private ip address in '/etc/iscsi/ifaces/' iface file.
>>
>> +/**
>> + * cxgb3i_find_dev - find the interface associated with the given address
>> + * @ipaddr: ip address
>> + */
>> +static struct net_device *cxgb3i_find_dev(__be32 ipaddr)
>> +{
>> +	struct flowi fl;
>> +	int err;
>> +	struct rtable *rt;
>> +
>> +	memset(&fl, 0, sizeof(fl));
>> +	fl.nl_u.ip4_u.daddr = ipaddr;
>> +
>> +	err = ip_route_output_key(&init_net, &rt, &fl);
>> +	if (!err)
>> +		return (&rt->u.dst)->dev;
>> +
>> +	return NULL;
>> +}
> 
> This probably shouldn't be using init_net but the current namespace.

Hi Patrick,

Thanks for review, will fix that and send another path shortly.

Regards
Rakesh Ranjan



Download attachment "signature.asc" of type "application/pgp-signature" (899 bytes)