linux-kernel - Re: GPIO support for HTC Dream

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091210162645.GG19454@elf.ucw.cz>
Date:	Thu, 10 Dec 2009 17:26:45 +0100
From:	Pavel Machek <pavel@....cz>
To:	Ryan Mallon <ryan@...ewatersys.com>
Cc:	Arve Hj?nnev?g <arve@...roid.com>,
	kernel list <linux-kernel@...r.kernel.org>,
	linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
	Brian Swetland <swetland@...gle.com>,
	Daniel Walker <dwalker@...eaurora.org>,
	Iliyan Malchev <malchev@...gle.com>
Subject: Re: GPIO support for HTC Dream

Hi!

> >>> +#define DREAM_INT_TO_BANK(n) ((n - DREAM_INT_START) / DREAM_INT_BANK0_COUNT)
> >>> +#define DREAM_INT_TO_MASK(n) (1U << ((n - DREAM_INT_START) & 7))
> >>> +#define DREAM_BANK_TO_MASK_REG(bank) \
> >>> +	(bank ? DREAM_GPIO_INT_MASK1_REG : DREAM_GPIO_INT_MASK0_REG)
> >>> +#define DREAM_BANK_TO_STAT_REG(bank) \
> >>> +	(bank ? DREAM_GPIO_INT_STAT1_REG : DREAM_GPIO_INT_STAT0_REG)
> >> Are these needed outside of the gpiolib code? If not, they should be
> >> moved there. I also think they should have lower case names since they
> >> act like a function, and make the code where they are used nicer to
> >> read.
> > 
> > I guess these logically belong here.
> > 
> > No, macros are macros, that means upcase.
> 
> container_of, min, swap, etc are macros too. It is easier to read this
> if they are lower case because they are typically used for initialising
> variables, ie:
> 
> 	int bank = dream_int_to_bank(irq);
> 
> Is easier (IMHO) to read than:
> 	
> 	int bank = DREAM_INT_TO_BANK(irq);

I disagree here. I could convert it to inline function, but I guess it
is okay as it is.

> >  static void __init dream_init(void)
> >  {
> > +	gpio_set_value(DREAM_GPIO_UI_LED_EN, 1);
> > +        mdelay(300);
> > +	gpio_set_value(DREAM_GPIO_UI_LED_EN, 0);
> > +        mdelay(300);
> > +        gpio_set_value(DREAM_GPIO_UI_LED_EN, 1);
> > +	mdelay(300);
> > +        gpio_set_value(DREAM_GPIO_UI_LED_EN, 0);
> > +	mdelay(300);
> > +        gpio_set_value(DREAM_GPIO_UI_LED_EN, 1);
> > +        mdelay(300);
> > +        gpio_set_value(DREAM_GPIO_UI_LED_EN, 0);
> > +        mdelay(300);
> > +	gpio_set_value(DREAM_GPIO_UI_LED_EN, 1);
> > +        mdelay(300);
> > +	gpio_set_value(DREAM_GPIO_UI_LED_EN, 0);
> > +        mdelay(300);
> > +
> 
> Indentation looks screwy here. Also, is this meant to blink the leds?
> There is a 2.4 second hard delay here, which is horrible.

Yep, that was my debugging code, not meant for upstream. And yes, its
blinking.
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/