linux-kernel - Re: [2.6.32] WARNING: at arch/x86/kernel/apic/apic.c:249 native_apic_write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091210164904.GE5086@lenovo>
Date:	Thu, 10 Dec 2009 19:49:04 +0300
From:	Cyrill Gorcunov <gorcunov@...il.com>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	Ralf Hildebrandt <Ralf.Hildebrandt@...rite.de>,
	linux-kernel@...r.kernel.org, x86team <x86@...nel.org>
Subject: Re: [2.6.32] WARNING: at arch/x86/kernel/apic/apic.c:249
	native_apic_write_dummy+0x30/0x3c()

On Thu, Dec 10, 2009 at 05:37:45PM +0100, Ingo Molnar wrote:
...
> >  
> > +	perfmon_check_apic(&x86_pmu);
> > +
> >  	return 0;
> >  }
> 
> Similar check needed in intel_pmu_init() as well?

Yes (though p6 model already has such a check [fixed by Peter iirc])

>
> Also, i'd suggest to 
> name it pmu_check_apic() or so - and why call it in the middle of of the 
> PMU init functions? All PMU drivers are APIC based, so this call can be 
> done right after:
> 
>         if (err != 0) {
>                 pr_cont("no PMU driver, software events only.\n");
>                 return;
>         }
> 
> 	pmu_check_apic();
> 
> in a single place. Also, no need to pass in &x86_pmu - we have a single 
> PMU driver.
> 
> Thanks,
> 
> 	Ingo
> 

OK, will update and resend. Thanks for comments!

	-- Cyrill
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/