linux-kernel - Re: [RFC mm][PATCH 1/5] mm counter cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20091211084255.ec7d3f49.kamezawa.hiroyu@jp.fujitsu.com>
Date:	Fri, 11 Dec 2009 08:42:55 +0900
From:	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
To:	Christoph Lameter <cl@...ux-foundation.org>
Cc:	"linux-mm@...ck.org" <linux-mm@...ck.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
	minchan.kim@...il.com, mingo@...e.hu
Subject: Re: [RFC mm][PATCH 1/5] mm counter cleanup

On Thu, 10 Dec 2009 11:30:46 -0600 (CST)
Christoph Lameter <cl@...ux-foundation.org> wrote:

> On Thu, 10 Dec 2009, KAMEZAWA Hiroyuki wrote:
> 
> > This patch modifies it to
> >   - Define them in mm.h as inline functions
> >   - Use array instead of macro's name creation. For making easier to add
> >     new coutners.
> 
> Reviewed-by: Christoph Lameter <cl@...ux-foundation.org>
> 
> > @@ -454,8 +456,8 @@ static struct mm_struct * mm_init(struct
> >  		(current->mm->flags & MMF_INIT_MASK) : default_dump_filter;
> >  	mm->core_state = NULL;
> >  	mm->nr_ptes = 0;
> > -	set_mm_counter(mm, file_rss, 0);
> > -	set_mm_counter(mm, anon_rss, 0);
> > +	for (i = 0; i < NR_MM_COUNTERS; i++)
> > +		set_mm_counter(mm, i, 0);
> 
> 
> memset? Or add a clear_mm_counter function? This also occurred earlier in
> init_rss_vec().
> 
Ok, I'll try some cleaner codes.

Thanks,
-Kame

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/