linux-kernel - Re: [PATCH 2/2] tracing: Fix no callsite ifndef CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4B21E00D.1040103@cs.helsinki.fi>
Date:	Fri, 11 Dec 2009 08:00:45 +0200
From:	Pekka Enberg <penberg@...helsinki.fi>
To:	Li Zefan <lizf@...fujitsu.com>
CC:	Ingo Molnar <mingo@...e.hu>,
	Christoph Lameter <cl@...ux-foundation.org>,
	Steven Rostedt <rostedt@...dmis.org>,
	Frederic Weisbecker <fweisbec@...il.com>,
	"linux-mm@...ck.org" <linux-mm@...ck.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Eduard - Gabriel Munteanu <eduard.munteanu@...ux360.ro>
Subject: Re: [PATCH 2/2] tracing: Fix no callsite ifndef CONFIG_KMEMTRACE

Li Zefan wrote:
> For slab, if CONFIG_KMEMTRACE and CONFIG_DEBUG_SLAB are not set,
> __do_kmalloc() will not track callers:
> 
>  # ./perf record -f -a -R -e kmem:kmalloc
>  ^C
>  # ./perf trace
>  ...
>           perf-2204  [000]   147.376774: kmalloc: call_site=c0529d2d ...
>           perf-2204  [000]   147.400997: kmalloc: call_site=c0529d2d ...
>           Xorg-1461  [001]   147.405413: kmalloc: call_site=0 ...
>           Xorg-1461  [001]   147.405609: kmalloc: call_site=0 ...
>        konsole-1776  [001]   147.405786: kmalloc: call_site=0 ...
> 
> Signed-off-by: Li Zefan <lizf@...fujitsu.com>

Reviewed-by: Pekka Enberg <penberg@...helsinki.fi>

> ---
>  mm/slab.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/mm/slab.c b/mm/slab.c
> index e556380..eacf7f0 100644
> --- a/mm/slab.c
> +++ b/mm/slab.c
> @@ -3637,7 +3637,7 @@ __do_kmalloc_node(size_t size, gfp_t flags, int node, void *caller)
>  	return ret;
>  }
>  
> -#if defined(CONFIG_DEBUG_SLAB) || defined(CONFIG_KMEMTRACE)
> +#if defined(CONFIG_DEBUG_SLAB) || defined(CONFIG_TRACING)
>  void *__kmalloc_node(size_t size, gfp_t flags, int node)
>  {
>  	return __do_kmalloc_node(size, flags, node,
> @@ -3657,7 +3657,7 @@ void *__kmalloc_node(size_t size, gfp_t flags, int node)
>  	return __do_kmalloc_node(size, flags, node, NULL);
>  }
>  EXPORT_SYMBOL(__kmalloc_node);
> -#endif /* CONFIG_DEBUG_SLAB */
> +#endif /* CONFIG_DEBUG_SLAB || CONFIG_TRACING */
>  #endif /* CONFIG_NUMA */
>  
>  /**
> @@ -3689,7 +3689,7 @@ static __always_inline void *__do_kmalloc(size_t size, gfp_t flags,
>  }
>  
>  
> -#if defined(CONFIG_DEBUG_SLAB) || defined(CONFIG_KMEMTRACE)
> +#if defined(CONFIG_DEBUG_SLAB) || defined(CONFIG_TRACING)
>  void *__kmalloc(size_t size, gfp_t flags)
>  {
>  	return __do_kmalloc(size, flags, __builtin_return_address(0));

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/