linux-kernel - Return value of print_graph

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 11 Dec 2009 18:12:31 +0800
From:	Wenji Huang <wenji.huang@...cle.com>
To:	Frederic Weisbecker <fweisbec@...il.com>
CC:	Steven Rostedt <rostedt@...dmis.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Return value of print_graph_prologue

Hi,

I got confused about the return value of print_graph_prologue. See:

805         /* Latency format */
806         if (trace_flags & TRACE_ITER_LATENCY_FMT) {
807                 ret = print_graph_lat_fmt(s, ent);
808                 if (ret == TRACE_TYPE_PARTIAL_LINE)
809                         return TRACE_TYPE_PARTIAL_LINE;
810         }
811
812         return 0;
813 }

But we have defined TRACE_TYPE_PARTIAL_LINE = 0. So there's
no difference between success and failure?

Should it be TRACE_TYPE_HANDLED ?

Regards,
Wenji
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/