lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 11 Dec 2009 13:20:04 +0100 From: Frederic Riss <frederic.riss@...il.com> To: Li Zefan <lizf@...fujitsu.com> Cc: Steven Rostedt <rostedt@...dmis.org>, Ingo Molnar <mingo@...e.hu>, Frederic Weisbecker <fweisbec@...il.com>, Wenji Huang <wenji.huang@...cle.com>, LKML <linux-kernel@...r.kernel.org> Subject: Re: [PATCH 1/4] ftrace: Fix MATCH_END_ONLY filter matching 2009/12/11 Li Zefan <lizf@...fujitsu.com>: > For '*foo' pattern, we should allow any string ending with > 'foo', but ftrace filter incorrectly disallows strings > like bar_foo_foo: [...] > case MATCH_END_ONLY: > - ptr = strstr(str, regex); > - if (ptr && (ptr[len] == 0)) > + slen = strlen(str); > + if (slen >= len && memcpy(str + slen - len, regex, len)) > matched = 1; Shouldn't that be memcmp() == 0? I don't see how memcpy might serve as a compare operator. Fred. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists