linux-kernel - Re: [PATCH] tracing: add checks for printing graph irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20091211174425.GB5094@nowhere>
Date:	Fri, 11 Dec 2009 18:44:31 +0100
From:	Frederic Weisbecker <fweisbec@...il.com>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	Wenji Huang <wenji.huang@...cle.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tracing: add checks for printing graph irq

On Fri, Dec 11, 2009 at 10:00:50AM -0500, Steven Rostedt wrote:
> On Fri, 2009-12-11 at 12:19 +0100, Frederic Weisbecker wrote:
> > On Fri, Dec 11, 2009 at 05:38:35PM +0800, Wenji Huang wrote:
> > > Check return value of trace_seq_printf.
> > > 
> > > Signed-off-by: Wenji Huang <wenji.huang@...cle.com>
> > > ---
> > 
> > 
> > I'm applying it, I'll send the fix for the problem you've reported
> > at the same time.
> 
> As for my comment to the patch. Please do not apply this.
> 
> Thanks,


Ok. Yeah you're right, the seq buffer will refuse them once
it's fullfilled anyway, so only the last check matters, we have
too much of these checks in the current code.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/