linux-kernel - Re: [RFC/PATCH 2/5] usb: otg: twl4030: add support for notifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091211204014.GA30776@nokia.com>
Date:	Fri, 11 Dec 2009 22:40:14 +0200
From:	Felipe Balbi <felipe.balbi@...ia.com>
To:	ext sai pavan <saipavan.243@...il.com>
Cc:	"Balbi Felipe (Nokia-D/Helsinki)" <felipe.balbi@...ia.com>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Anton Vorontsov <avorontsov@...mvista.com>,
	Grazvydas Ignotas <notasas@...il.com>,
	Madhusudhan Chikkature <madhu.cr@...com>,
	"linux-omap@...r.kernel.org" <linux-omap@...r.kernel.org>,
	Greg Kroah-Hartman <gregkh@...e.de>,
	David Brownell <dbrownell@...rs.sourceforge.net>
Subject: Re: [RFC/PATCH 2/5] usb: otg: twl4030: add support for notifier

Hi,

On Fri, Dec 11, 2009 at 06:22:14PM +0100, ext sai pavan wrote:
>> @@ -628,7 +628,8 @@ static irqreturn_t twl4030_usb_irq(int irq, void *_twl)
>>                else
>>                        twl4030_phy_resume(twl);
>>
>> -               twl4030charger_usb_en(status == USB_LINK_VBUS);
>> +               blocking_notifier_call_chain(&twl->otg.notifier, status,
>> +                               twl->otg.gadget);
>>        }
>
>You might not want to invoke blocking notifier chain(may sleep) from
>interrupt context. May be atomic notifier chain is appropriate here.

that's a threaded irq. Maybe we should patch all twl children to use 
request_threaded_irq() already. I'll test that tomorrow.

-- 
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/