[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <BD79186B4FD85F4B8E60E381CAEE190901FB10EB@mi8nycmail19.Mi8.com>
Date: Fri, 11 Dec 2009 18:12:35 -0500
From: "H Hartley Sweeten" <hartleys@...ionengravers.com>
To: Arve Hjønnevåg <arve@...roid.com>,
"Pavel Machek" <pavel@....cz>
Cc: "Ryan Mallon" <ryan@...ewatersys.com>,
"Daniel Walker" <dwalker@...eaurora.org>,
"Iliyan Malchev" <malchev@...gle.com>,
"Brian Swetland" <swetland@...gle.com>,
"kernel list" <linux-kernel@...r.kernel.org>,
"linux-arm-kernel" <linux-arm-kernel@...ts.infradead.org>
Subject: RE: GPIO support for HTC Dream
On Friday, December 11, 2009 3:41 PM, Arve Hjønnevåg wrote:
<snip>
>> Now, it will still need some cleanups -- I'm not sure if gpios are
>> dream-specific or generic for whole msm.... I kind of assume they
>> should be generic for msm. Google people, can you help?
>
> I'm not exactly sure what you are asking. Gpios in general are not
> dream specific, the code in board-dream-gpio.c is. Some gpios (e.g.
> DREAM_4_BALL_UP_0) are used for a dream specific function, but point
> to a gpio that is generic to the msm architecture.
<snip>
>> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
>> index 1c4119c..8bb8546 100644
>> --- a/arch/arm/Kconfig
>> +++ b/arch/arm/Kconfig
>> @@ -565,6 +565,8 @@ config ARCH_MSM
>> select CPU_V6
>> select GENERIC_TIME
>> select GENERIC_CLOCKEVENTS
>> + select GENERIC_GPIO
>> + select ARCH_REQUIRE_GPIOLIB
>
> Please do not do this in a board specific change. You have not changed
> the msm generic gpio support to use gpiolib.
Where is the msm tree located? mach-msm in mainline doesn't appear to
have _any_ gpio support. Is Pavel's implementation generic enough to
work with any msm based board?
Regards,
Hartley
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists