| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20091212122443.GA8742@kernel.dk> Date: Sat, 12 Dec 2009 13:24:43 +0100 From: Jens Axboe <jens.axboe@...cle.com> To: Matthew Garrett <mjg@...hat.com> Cc: linux-kernel@...r.kernel.org Subject: Re: [PATCH] laptop-mode: Make flushes per-device On Fri, Dec 11 2009, Matthew Garrett wrote: > One of the features of laptop-mode is that it forces a writeout of dirty > pages if something else triggers a physical read or write from a device. > The current implementation flushes pages on all devices, rather than only > the one that triggered the flush. This patch alters the behaviour so that > only the recently accessed block device is flushed, preventing other > disks being spun up for no terribly good reason. > > Signed-off-by: Matthew Garrett <mjg@...hat.com> > --- > > The forward struct declaration in writeback.h seems messy, but I'm not > sure there's a cleaner way to do this. I'm also still woefully > unfamiliar with the block layer - I /think/ this does the right thing, > but some review would be nice. That's because it is messy, why are you passing the request in? It would be a lot more sane to pass in the queue, better still the backing device. What guarentees that the timer isn't running when the bdi goes away? -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists