linux-kernel - Re: [GIT PATCH] TTY patches for 2.6.33-git

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 13 Dec 2009 11:36:26 +0000
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Greg KH <gregkh@...e.de>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	linux-kernel@...r.kernel.org
Subject: Re: [GIT PATCH] TTY patches for 2.6.33-git

>  earth4:~/tip> git checkout linus
>  Date:   Fri Dec 11 20:58:20 2009 -0800
>  earth4:~/tip> git grep -w unlock_kernel | wc -l
>  841
> 
> we grew the (absolute) number of BKL sites by ~15%. Certainly the kernel grew 
> at a much faster rate, so the relative proportion of the BKL shrunk.

Thats actually very misleading. The reason is we have created more
lock/unlock points as we remove and drive down the lock.

By your metric the original SMP kernel was best - it had one of each 8)
	
> Also, a lot of BKL use was hidden before, and due to the BKL removal 
> activities (by Thomas, Frederic, Jon, Alan and others) the remaining BKL using 
> sites are a lot more well defined, a lot more isolated and thus a lot more 
> removable than ever before.

ioctl is almost done and I've gont some other random ones in my tree.
lseek is close. At that point most of the nasties are squashed except tty.

We do have some remaining locking horrors some partly introduced by the
finer locking work in the past including the rather nasty device
unload/load v open file handle races.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/