linux-kernel - Re: [GIT PATCH] TTY patches for 2.6.33-git

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 13 Dec 2009 14:09:14 -0500
From:	Trond Myklebust <trond.myklebust@....uio.no>
To:	Frederic Weisbecker <fweisbec@...il.com>
Cc:	Ingo Molnar <mingo@...e.hu>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Alan Cox <alan@...rguk.ukuu.org.uk>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Greg KH <gregkh@...e.de>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	linux-kernel@...r.kernel.org
Subject: Re: [GIT PATCH] TTY patches for 2.6.33-git

On Sun, 2009-12-13 at 20:04 +0100, Frederic Weisbecker wrote: 
> In the above cases we have the following comment:
> 
> /* Protect inode->i_flock using the BKL */
> 
> And really it doesn't seem to protect anything else,
> fortunately it is acquired in a short path.

As I said in my reply, this is the tough one, because the BKL protection
is imposed by the VFS locking scheme used in fs/locks.c.

There is a similar dependency imposed upon fs/lockd/

I'm working on this, but I don't have anything ready for 2.6.33. 

> fs/nfs/super.c: unlock_kernel();
> fs/nfs/super.c: unlock_kernel();
> 
> Protect the mount/unmount path, a bit trickier there.
> 
> But really that looks way much easier to fix than it was
> with reiserfs.

All the other cases you list should be fixed in the GIT PULL request
that I just put out.

Trond

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/