linux-kernel - Re: [PATCH] Keys: KEYCTL_SESSION_TO_PARENT needs TIF_NOTIFY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LRH.2.00.0912140828430.25093@tundra.namei.org>
Date:	Mon, 14 Dec 2009 08:29:20 +1100 (EST)
From:	James Morris <jmorris@...ei.org>
To:	Geert Uytterhoeven <geert@...ux-m68k.org>
cc:	David Howells <dhowells@...hat.com>,
	Linux/m68k <linux-m68k@...r.kernel.org>,
	Mike Frysinger <vapier@...too.org>,
	Chris Zankel <chris@...kel.net>,
	Linux Kernel Development <linux-kernel@...r.kernel.org>,
	linux-security-module@...r.kernel.org
Subject: Re: [PATCH] Keys: KEYCTL_SESSION_TO_PARENT needs TIF_NOTIFY_RESUME
 architecture support

On Sun, 13 Dec 2009, Geert Uytterhoeven wrote:

> As of commit ee18d64c1f632043a02e6f5ba5e045bb26a5465f ("KEYS: Add a keyctl to
> install a process's session keyring on its parent [try #6]"), CONFIG_KEYS=y
> fails to build on architectures that haven't implemented TIF_NOTIFY_RESUME yet:
> 
> security/keys/keyctl.c: In function 'keyctl_session_to_parent':
> security/keys/keyctl.c:1312: error: 'TIF_NOTIFY_RESUME' undeclared (first use in this function)
> security/keys/keyctl.c:1312: error: (Each undeclared identifier is reported only once
> security/keys/keyctl.c:1312: error: for each function it appears in.)
> 
> Make KEYCTL_SESSION_TO_PARENT depend on TIF_NOTIFY_RESUME until blackfin,
> m68k, and xtensa have implemented it.
> 
> Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>
> Cc: stable@...nel.org

Looks ok to me -- once we have an ack from David, I'll add it to my tree 
and push to Linus with another fix.

> ---
> 1. This fixes a regression in 2.6.32.
> 2. Long-time build issues like this make linux-next miss newer build 
>    problems.
> 
>  security/keys/keyctl.c |   10 ++++++++++
>  1 files changed, 10 insertions(+), 0 deletions(-)
> 
> diff --git a/security/keys/keyctl.c b/security/keys/keyctl.c
> index 06ec722..3a9ad87 100644
> --- a/security/keys/keyctl.c
> +++ b/security/keys/keyctl.c
> @@ -1236,6 +1236,7 @@ long keyctl_get_security(key_serial_t keyid,
>   */
>  long keyctl_session_to_parent(void)
>  {
> +#ifdef TIF_NOTIFY_RESUME
>  	struct task_struct *me, *parent;
>  	const struct cred *mycred, *pcred;
>  	struct cred *cred, *oldcred;
> @@ -1326,6 +1327,15 @@ not_permitted:
>  error_keyring:
>  	key_ref_put(keyring_r);
>  	return ret;
> +
> +#else /* !TIF_NOTIFY_RESUME */
> +	/*
> +	 * To be removed when TIF_NOTIFY_RESUME has been implemented on
> +	 * blackfin/m68k/xtensa
> +	 */
> +#warning TIF_NOTIFY_RESUME not implemented
> +	return -EOPNOTSUPP;
> +#endif /* !TIF_NOTIFY_RESUME */
>  }
>  
>  /*****************************************************************************/
> -- 
> 1.6.0.4
> 
> Gr{oetje,eeting}s,
> 
> 						Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> 							    -- Linus Torvalds
> 

-- 
James Morris
<jmorris@...ei.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/