linux-kernel - Re: [PATCH] ataflop: Killl warning about unused variable flags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.0912132337400.3755@pobox.suse.cz>
Date:	Sun, 13 Dec 2009 23:38:26 +0100 (CET)
From:	Jiri Kosina <jkosina@...e.cz>
To:	Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:	Jens Axboe <jens.axboe@...cle.com>,
	Michael Schmitz <schmitz@...phys.uni-duesseldorf.de>,
	Linux/m68k <linux-m68k@...ts.linux-m68k.org>,
	Linux Kernel Development <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ataflop: Killl warning about unused variable flags

On Sun, 13 Dec 2009, Geert Uytterhoeven wrote:

> After commit e0c0978699a83f26f2341f7eedc1463b79e31aff ("ataflop: remove
> buggy/commented-out IRQ disable from do_fd_request()") the `flags' variable
> became unused:
> 
> drivers/block/ataflop.c:1473: warning: unused variable 'flags'
> 
> Hence remove it.
> 
> Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>
> ---
>  drivers/block/ataflop.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/block/ataflop.c b/drivers/block/ataflop.c
> index a5af1d6..e35cf59 100644
> --- a/drivers/block/ataflop.c
> +++ b/drivers/block/ataflop.c
> @@ -1470,8 +1470,6 @@ repeat:
>  
>  void do_fd_request(struct request_queue * q)
>  {
> - 	unsigned long flags;
> -

Ah, I forogt to remove this one, thanks for noticing. I have queued your 
patch in my tree.

Thanks,

-- 
Jiri Kosina
SUSE Labs, Novell Inc.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/