linux-kernel - Re: [PATCH] au1xxx-ide.c: ioremap() returns a void _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4B241F10.7050706@ru.mvista.com>
Date:	Sun, 13 Dec 2009 01:54:08 +0300
From:	Sergei Shtylyov <sshtylyov@...mvista.com>
To:	H Hartley Sweeten <hartleys@...ionengravers.com>
Cc:	kernel list <linux-kernel@...r.kernel.org>,
	linux-ide@...r.kernel.org, David Miller <davem@...emloft.net>
Subject: Re: [PATCH] au1xxx-ide.c: ioremap() returns a void __iomem *

Hello.

H Hartley Sweeten wrote:

> The ioremap return value is an __iomem *, not an integer.  Update the
> private structure to reflect this.  While here, remove the typedef
> for _auide_hwif and just use struct auide_hwif instead as recommended
> by Documentation/CodingStyle.
>
> auide_setup_ports() still needs to cast the regbase back to an integer
> to correctly setup the io_ports_array.
>
> Signed-off-by: H Hartley Sweeten <hsweeten@...ionengravers.com>
> Cc: David Miller <davem@...emloft.net>
>
> ---
>
> diff --git a/Documentation/mips/AU1xxx_IDE.README b/Documentation/mips/AU1xxx_IDE.README
> index 8ace35e..37c6c34 100644
> --- a/Documentation/mips/AU1xxx_IDE.README
> +++ b/Documentation/mips/AU1xxx_IDE.README
> @@ -45,7 +45,7 @@ FILES, CONFIGS AND COMPATABILITY
>  Two files are introduced:
>  
>    a) 'arch/mips/include/asm/mach-au1x00/au1xxx_ide.h'
> -     containes : struct _auide_hwif
> +     containes : struct auide_hwif
>   

   Contains?

   Other than that,

Acked-by: Sergei Shtylyov <sshtylyov@...mvista.com>

MBR, Sergei


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/