linux-kernel - Re: usb_autopm_*() removal build failure...

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20091212064620.GA13405@suse.de>
Date:	Fri, 11 Dec 2009 22:46:20 -0800
From:	Greg KH <gregkh@...e.de>
To:	David Miller <davem@...emloft.net>
Cc:	stern@...land.harvard.edu, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: usb_autopm_*() removal build failure...

On Fri, Dec 11, 2009 at 09:47:14PM -0800, David Miller wrote:
> From: Greg KH <gregkh@...e.de>
> Date: Fri, 11 Dec 2009 20:05:24 -0800
> 
> > Here's the patch, sent back in August:
> > 	 http://marc.info/?l=linux-netdev&m=125071045301270&w=2
> > 
> > Can you take it from there, or do you need me to forward it on?
> 
> I tossed this into the net-2.6 tree, but...
> 
> I would recommend that in the future when you have the
> dependency of an API change that's going to break the
> build, you take in the necessary change.  And you make
> sure such a commit is in your tree before the commit
> that removes the API.

I did at first, so I dropped the API change from my tree.  Then Alan and
Oliver pointed out that the changes were already in your tree, and I
looked and saw the first one, so just assumed the 2 other ones were
there, and turned off all network USB drivers in my build in order to
handle this.

Then yesterday, Stephen reported that this one driver failed to build,
which I didn't pick up on until today, after the tree had been sent to
Linus.

So, a mixup on my part, I'm sorry about that.

> Anyways, next time, please resolve API issues internally when you
> do things that will break the build otherwise.

Will do.

thanks for your patience.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/