linux-kernel - Re: [PATCH 05/10] Constify struct platform_suspend

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091214051745.GG5114@elf.ucw.cz>
Date:	Mon, 14 Dec 2009 06:17:45 +0100
From:	Pavel Machek <pavel@....cz>
To:	re.emese@...il.com
Cc:	linux-kernel@...r.kernel.org, len.brown@...el.com,
	akpm@...ux-foundation.org, torvalds@...ux-foundation.org
Subject: Re: [PATCH 05/10] Constify struct platform_suspend_ops for
 2.6.32-git-053fe57ac v2

On Mon 2009-12-14 01:00:21, re.emese@...il.com wrote:
> From: Emese Revfy <re.emese@...il.com>
> 
> 
> Signed-off-by: Emese Revfy <re.emese@...il.com>

It definitely needs an explanation, and it has none.

> index 5e781d8..3a2553d 100644
> --- a/include/linux/suspend.h
> +++ b/include/linux/suspend.h
> @@ -104,15 +104,15 @@ typedef int __bitwise suspend_state_t;
>   *	which require special recovery actions in that situation.
>   */
>  struct platform_suspend_ops {
> -	int (*valid)(suspend_state_t state);
> -	int (*begin)(suspend_state_t state);
> -	int (*prepare)(void);
> -	int (*prepare_late)(void);
> -	int (*enter)(suspend_state_t state);
> -	void (*wake)(void);
> -	void (*finish)(void);
> -	void (*end)(void);
> -	void (*recover)(void);
> +	int (* const valid)(suspend_state_t state);
> +	int (* const begin)(suspend_state_t state);
> +	int (* const prepare)(void);
> +	int (* const prepare_late)(void);
> +	int (* const enter)(suspend_state_t state);
> +	void (* const wake)(void);
> +	void (* const finish)(void);
> +	void (* const end)(void);
> +	void (* const recover)(void);
>  };
>

I'm not sure what this is good for. Are you afraid that I'd do 
*(char *)ops->end = 0x90 , or what?

> @@ -120,7 +120,7 @@ struct platform_suspend_ops {
>   * suspend_set_ops - set platform dependent suspend operations
>   * @ops: The new suspend operations to set.
>   */
> -extern void suspend_set_ops(struct platform_suspend_ops *ops);
> +extern void suspend_set_ops(const struct platform_suspend_ops *ops);
>  extern int suspend_valid_only_mem(suspend_state_t state);
>

These I can at least understand, and are probably ok.

									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/