linux-kernel - Re: [tip:perf/urgent] hw-breakpoints: Let modify_user_hw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20091214105435.GA15766@elte.hu>
Date:	Mon, 14 Dec 2009 11:54:35 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Stephen Rothwell <sfr@...b.auug.org.au>
Cc:	mingo@...hat.com, hpa@...or.com, linux-kernel@...r.kernel.org,
	fweisbec@...il.com, heiko.carstens@...ibm.com, tglx@...utronix.de,
	linux-tip-commits@...r.kernel.org
Subject: Re: [tip:perf/urgent] hw-breakpoints: Let
 modify_user_hw_breakpoint() return an int


* Stephen Rothwell <sfr@...b.auug.org.au> wrote:

> Hi Ingo,
> 
> On Mon, 14 Dec 2009 09:49:44 GMT tip-bot for Heiko Carstens <heiko.carstens@...ibm.com> wrote:
> >
> > Commit-ID:  4983ee49cf0393fd786891dd53af41146cf9f98b
> > Gitweb:     http://git.kernel.org/tip/4983ee49cf0393fd786891dd53af41146cf9f98b
> > Author:     Heiko Carstens <heiko.carstens@...ibm.com>
> > AuthorDate: Mon, 14 Dec 2009 10:24:12 +0100
> > Committer:  Ingo Molnar <mingo@...e.hu>
> > CommitDate: Mon, 14 Dec 2009 10:42:57 +0100
> > 
> > hw-breakpoints: Let modify_user_hw_breakpoint() return an int
> > 
> > Let modify_user_hw_breakpoint return an int to avoid hundreds of
> > compile warnings like this one:
> > 
> >  include/linux/hw_breakpoint.h: In function 'modify_user_hw_breakpoint':
> >  include/linux/hw_breakpoint.h:96:
> >   warning: return makes integer from pointer without a cast
> > 
> > Signed-off-by: Heiko Carstens <heiko.carstens@...ibm.com>
> > Cc: Frederic Weisbecker <fweisbec@...il.com>
> > LKML-Reference: <20091214092412.GA5242@...ris.boeblingen.de.ibm.com>
> > Signed-off-by: Ingo Molnar <mingo@...e.hu>
> > ---
> >  include/linux/hw_breakpoint.h |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/include/linux/hw_breakpoint.h b/include/linux/hw_breakpoint.h
> > index 41235c9..3f3ac2f 100644
> > --- a/include/linux/hw_breakpoint.h
> > +++ b/include/linux/hw_breakpoint.h
> > @@ -90,7 +90,7 @@ static inline struct arch_hw_breakpoint *counter_arch_bp(struct perf_event *bp)
> >  static inline struct perf_event *
> >  register_user_hw_breakpoint(struct perf_event_attr *attr,
> >  			    perf_overflow_handler_t triggered,
> > -			    struct task_struct *tsk)	{ return NULL; }
> > +			    struct task_struct *tsk)	{ return 0; }
> >  static inline int
> >  modify_user_hw_breakpoint(struct perf_event *bp,
> >  			  struct perf_event_attr *attr)	{ return -ENOSYS; }
> 
> This applied incorrectly ... it was a fix for modify_user_hw_breakpoint(), 
> but that fix has already bee applied to perf/urgent ...

yeah ... zapped it.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/