linux-kernel - Re: [RFC/PATCH 2/4] input: misc: twl4030: move to request_threaded

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 14 Dec 2009 13:40:09 +0200
From:	Felipe Balbi <felipe.balbi@...ia.com>
To:	"ext Shilimkar, Santosh" <santosh.shilimkar@...com>
Cc:	"Balbi Felipe (Nokia-D/Helsinki)" <felipe.balbi@...ia.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Linux OMAP Mailing List <linux-omap@...r.kernel.org>,
	Tony Lindgren <tony@...mide.com>,
	"Koskinen Aaro (Nokia-D/Helsinki)" <aaro.koskinen@...ia.com>,
	David Brownell <david-b@...bell.net>,
	Linux USB Mailing List <linux-usb@...r.kernel.org>,
	Anton Vorontsov <avorontsov@...mvista.com>,
	Grazvydas Ignotas <notasas@...il.com>,
	"Chikkature Rajashekar, Madhusudhan" <madhu.cr@...com>,
	Greg Kroah-Hartman <gregkh@...e.de>,
	Mark Brown <broonie@...nsource.wolfsonmicro.com>,
	Samuel Ortiz <sameo@...nedhand.com>
Subject: Re: [RFC/PATCH 2/4] input: misc: twl4030: move to
 request_threaded_irq

Hi,

On Mon, Dec 14, 2009 at 12:31:11PM +0100, ext Shilimkar, Santosh wrote:
>In whole of the series the ISR you have converted to threads using threaded_irq are very
>small in size. They are like quick_change_handlers. So only advantage is the particular
>interrupt is masked for bit longer than with you change.
>
>I might be wrong here but it might introduce the spurious IRQ's because 
>of bit of delay in the processing.What is the motive for this change ? 
>Are we using this API as it suppose to be ?

the irq chip is connected through i2c and that mandate us to handle irqs 
in thread context. Now that we have kernel-wise api for that, we're just 
moving towards it instead of definint our own stuff and the lockdep 
shortcuts we had to put before.

I boot tested these patches on a 3430-based board and it seems to be 
working fine. Did a few tests with usb only. I can see I get the usb 
presence irq correctly.

-- 
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/