linux-kernel - RE: [PATCH] au1xxx-ide.c: ioremap() returns a void _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 14 Dec 2009 12:27:29 -0500
From:	"H Hartley Sweeten" <hartleys@...ionengravers.com>
To:	"David Miller" <davem@...emloft.net>, <sshtylyov@...mvista.com>
Cc:	<linux-kernel@...r.kernel.org>, <linux-ide@...r.kernel.org>
Subject: RE: [PATCH] au1xxx-ide.c: ioremap() returns a void __iomem *

On Sunday, December 13, 2009 9:52 PM, David Miller wrote:
>
> From: Sergei Shtylyov <sshtylyov@...mvista.com>
> Date: Sun, 13 Dec 2009 01:54:08 +0300
> 
>> H Hartley Sweeten wrote:
>> 
>>> The ioremap return value is an __iomem *, not an integer.  Update the
>>> private structure to reflect this.  While here, remove the typedef
>>> for _auide_hwif and just use struct auide_hwif instead as recommended
>>> by Documentation/CodingStyle.
>>>
>>> auide_setup_ports() still needs to cast the regbase back to an integer
>>> to correctly setup the io_ports_array.
>>>
>>> Signed-off-by: H Hartley Sweeten <hsweeten@...ionengravers.com>
 ...
>>>     a) 'arch/mips/include/asm/mach-au1x00/au1xxx_ide.h'
>>> -     containes : struct _auide_hwif
>>> +     containes : struct auide_hwif
>>>   
>> 
>>   Contains?
>> 
>>   Other than that,
>> 
>> Acked-by: Sergei Shtylyov <sshtylyov@...mvista.com>

Oops... Did not notice that spelling error.  Will fix and repost the patch.

> Also, this patch doesn't apply to the current tree, the
> au_ide_remove() function has been fixed to use
> resource_size().
>
> Please respin your patch, and also incorporate the
> documentation spelling fix suggested by Sergei (and
> make sure to keep the alignment of that section of
> documentation when you do that).

Hmmm.. That patch was also mine.  I waited until it was merged before creating
this one. It should have accounted for that.  I will recheck the patch to see
what was missed.

Regards,
Hartley
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/