linux-kernel - Re: [PATCH] acpi: fix for lapic_timer_propagate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1260815843.4243.1.camel@sbs-t61.sc.intel.com>
Date:	Mon, 14 Dec 2009 10:37:22 -0800
From:	Suresh Siddha <suresh.b.siddha@...el.com>
To:	Hidetoshi Seto <seto.hidetoshi@...fujitsu.com>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
	"Brown, Len" <len.brown@...el.com>
Subject: Re: [PATCH] acpi: fix for lapic_timer_propagate_broadcast()

On Mon, 2009-12-14 at 00:10 -0800, Hidetoshi Seto wrote:
> I got following warning on ia64 box:
>   In function 'acpi_processor_power_verify':
>   642: warning: passing argument 2 of 'smp_call_function_single' from
>   incompatible pointer type
> 
> This smp_call_function_single() was introduced by a commit
> f833bab87fca5c3ce13778421b1365845843b976:
> 
>  > @@ -162,8 +162,9 @@
>  >               pr->power.timer_broadcast_on_state = state;
>  >  }
>  >
>  > -static void lapic_timer_propagate_broadcast(struct acpi_processor *pr)
>  > +static void lapic_timer_propagate_broadcast(void *arg)
>  >  {
>  > +       struct acpi_processor *pr = (struct acpi_processor *) arg;
>  >         unsigned long reason;
>  >
>  >         reason = pr->power.timer_broadcast_on_state < INT_MAX ?
>  > @@ -635,7 +636,8 @@
>  >                 working++;
>  >         }
>  >
>  > -       lapic_timer_propagate_broadcast(pr);
>  > +       smp_call_function_single(pr->id, lapic_timer_propagate_broadcast,
>  > +                                pr, 1);
>  >
>  >         return (working);
>  >  }
> 
> The problem is that the lapic_timer_propagate_broadcast() has 2 versions:
> One is real code that modified in the above commit, and the other is NOP
> code that used when !ARCH_APICTIMER_STOPS_ON_C3:
> 
>   static void lapic_timer_propagate_broadcast(struct acpi_processor *pr) { }
> 
> So I got warning because of !ARCH_APICTIMER_STOPS_ON_C3.
> 
> We really want to do nothing here on !ARCH_APICTIMER_STOPS_ON_C3, so
> modify lapic_timer_propagate_broadcast() of real version to use
> smp_call_function_single() in it.
> 
> Signed-off-by: Hidetoshi Seto <seto.hidetoshi@...fujitsu.com>

Acked-by: Suresh Siddha <suresh.b.siddha@...el.com>

Len, please push this in to your tree.

thanks,
suresh

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/